From 691ca93c820d91d61aab25e752734f229a18d433 Mon Sep 17 00:00:00 2001
From: xboard <xboard>
Date: Wed, 25 Mar 2026 18:31:37 +0800
Subject: [PATCH] fix: update existing limiter rates & adapt flush test for
 dedup

---
 internal/limiter/speedtracker.go | 18 ++++++++++++++++--
 internal/tracker/tracker_test.go |  6 +++---
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/internal/limiter/speedtracker.go b/internal/limiter/speedtracker.go
index 8ea566b..1dee5e8 100644
--- a/internal/limiter/speedtracker.go
+++ b/internal/limiter/speedtracker.go
@@ -43,8 +43,7 @@ func (t *SpeedTracker) SetLogCallback(f SpeedTrackerLogCallback) {
 	t.logFunc = f
 }
 
-// UpdateBuckets updates the UUID→userID mapping and cleans up removed users.
-// Rate limiters are created on-demand in GetLimiter.
+// UpdateBuckets updates the UUID→userID mapping and syncs existing limiters.
 func (t *SpeedTracker) UpdateBuckets() {
 	currentUsers := make([]panel.User, 0, 32)
 	t.limiter.mu.RLock()
@@ -65,6 +64,21 @@ func (t *SpeedTracker) UpdateBuckets() {
 			if user.UUID != "" {
 				newUUIDMap[user.UUID] = user.ID
 			}
+
+			// Update existing limiter if speed changed
+			if lim, ok := t.buckets[user.ID]; ok {
+				if user.SpeedLimit > 0 {
+					bytesPerSec := int(user.SpeedLimit) * 1_000_000 / 8
+					burst := bytesPerSec
+					if burst < 64*1024 {
+						burst = 64 * 1024
+					}
+					lim.SetLimit(rate.Limit(bytesPerSec))
+					lim.SetBurst(burst)
+				} else {
+					delete(t.buckets, user.ID)
+				}
+			}
 		}
 
 		// Clean up buckets for removed users
diff --git a/internal/tracker/tracker_test.go b/internal/tracker/tracker_test.go
index 75f51f9..8035573 100644
--- a/internal/tracker/tracker_test.go
+++ b/internal/tracker/tracker_test.go
@@ -164,10 +164,10 @@ func TestFlushAliveIPs(t *testing.T) {
 		t.Errorf("user 2 IPs: got %d, want 1", len(flushed[2]))
 	}
 
-	// Without another Process call, aliveIPs still reflect last known state
+	// Without another Process call, hash is same → returns nil (skip duplicate)
 	flushed2 := tr.FlushAliveIPs()
-	if len(flushed2[1]) != 2 {
-		t.Errorf("expected same IPs without new Process, got %v", flushed2)
+	if flushed2 != nil {
+		t.Errorf("expected nil on duplicate flush, got %v", flushed2)
 	}
 }